caicancai commented on code in PR #3310:
URL:
https://github.com/apache/incubator-streampark/pull/3310#discussion_r1382343339
##########
streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/ApplicationBackUpService.java:
##########
@@ -74,7 +74,7 @@ public interface ApplicationBackUpService extends
IService<ApplicationBackUp> {
*
* @param appParam the application to be removed
*/
- void removeApp(Application appParam);
+ void removeByApp(Application appParam);
Review Comment:
Some places are Boolean remove (Application appParam); Could you please
check it out?
##########
streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/application/ApplicationManageService.java:
##########
@@ -105,7 +105,7 @@ public interface ApplicationManageService extends
IService<Application> {
* @param appParam The Application to be deleted.
* @return True if the deletion was successful, false otherwise.
*/
- Boolean delete(Application appParam);
+ Boolean remove(Application appParam);
Review Comment:
this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
