caicancai commented on code in PR #3310:
URL:
https://github.com/apache/incubator-streampark/pull/3310#discussion_r1382341972
##########
streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/VariableService.java:
##########
@@ -75,7 +75,7 @@ public interface VariableService extends IService<Variable> {
*
* @param variable the Variable object to be deleted
*/
- void deleteVariable(Variable variable);
+ void removeVariable(Variable variable);
Review Comment:
removeByVariable or remove?
##########
streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/ApplicationLogService.java:
##########
@@ -27,7 +27,7 @@ public interface ApplicationLogService extends
IService<ApplicationLog> {
IPage<ApplicationLog> getPage(ApplicationLog applicationLog, RestRequest
request);
- void removeApp(Long appId);
+ void removeByAppId(Long appId);
- Boolean delete(ApplicationLog applicationLog);
+ boolean removeById(ApplicationLog applicationLog);
Review Comment:
removeById？There is no id in the parameters
##########
streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/ApplicationLogService.java:
##########
@@ -27,7 +27,7 @@ public interface ApplicationLogService extends
IService<ApplicationLog> {
IPage<ApplicationLog> getPage(ApplicationLog applicationLog, RestRequest
request);
- void removeApp(Long appId);
+ void removeByAppId(Long appId);
- Boolean delete(ApplicationLog applicationLog);
+ boolean removeById(ApplicationLog applicationLog);
Review Comment:
removeById？There is no id in the parameters
##########
streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/controller/FlinkEnvController.java:
##########
@@ -96,7 +96,7 @@ public RestResponse update(FlinkEnv version) throws Exception
{
@Operation(summary = "Delete flink environment")
@PostMapping("delete")
public RestResponse delete(Long id) {
- flinkEnvService.delete(id);
+ flinkEnvService.remove(id);
Review Comment:
removeById
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
