janhoy commented on PR #827:
URL: https://github.com/apache/solr-operator/pull/827#issuecomment-6988605665
> how many of these checks are "is this solr 8" vs "is this solr 10"?
I reworked the checks in 6471c8a so each one names the oldest Solr version
that needs the old code path:
- `SolrVersionBelow("9")`: the listen/advertise env vars.
- `SolrVersionBelow("9.7")`: `solr api --solr-url` and `solr cluster
--property` both exist since 9.7, so the probe flag and the TLS urlScheme setup
go away once 9.7 is the minimum.
- `SolrVersionAtLeast("10")`: only the true 9-vs-10 differences remain.
These are the probe credentials (see the inline reply) and `solr.xml`. Solr 10
refuses to start with `hostContext`/`genericCoreNodeNames`, which Solr 9
requires. If Solr 10.x tolerated those two settings, the `solr.xml` switch
could go.
The Solr version is now a `version.Version` (k8s apimachinery) instead of a
major-version int.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]