janhoy commented on code in PR #827:
URL: https://github.com/apache/solr-operator/pull/827#discussion_r4619308285
##########
controllers/util/solr_util.go:
##########
@@ -431,6 +441,19 @@ func GenerateStatefulSet(solrCloud *solr.SolrCloud,
solrCloudStatus *solr.SolrCl
},
}
+ // Solr 10+ reads the listen port from SOLR_PORT_LISTEN instead of
SOLR_PORT,
+ // and uses SOLR_HOST_ADVERTISE in place of the deprecated 'host'
sysprop.
+ // These are only set for Solr 10+, so that pods of older Solr versions
are not restarted by an operator upgrade.
+ if solrCloud.SolrVersionAtLeast(10) {
Review Comment:
Good point, done in 2be5cc7: no Solr release before 10 reads these two
variables, so they are now set for all Solr versions without a version check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]