nick-boss-tech commented on PR #5326: URL: https://github.com/apache/solr/pull/5326#issuecomment-6858407160
Looks good. One issue: [PluginInfo.EMPTY_INFO](https://github.com/apache/solr/blob/1faf6287924b8bd3328796c66cb9ad3cfb1c79c6/solr/core/src/java/org/apache/solr/core/PluginInfo.java#L248) passes a SimpleOrderedMap to a constructor that immediately copies its entries into a plain NamedList. The substitution therefore has no effect on EMPTY_INFO.initArgs. The edit could be removed, or the intended behavior clarified. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
