isaric opened a new pull request, #5326: URL: https://github.com/apache/solr/pull/5326
https://issues.apache.org/jira/browse/SOLR-18612 # Description SIP-22 step 5, second slice (after #5311 for SolrJ). This PR covers the `solr/core` sites where a `NamedList` is created only to hold plugin init args or configuration, so it never reaches a response: 12 sites in 11 files. The core work is split by area so each PR stays reviewable: this one (init args and config), then the cluster and backup admin APIs, then the search handlers and components. The later two change JSON output under the default `json.nl` and will carry the changelog entry and the upgrade note; this one does not change anything a user can see. # Solution Each site now creates a `SimpleOrderedMap`: - empty init args passed to `init(...)`: `SchemaCodecFactory` fallback in `SolrCore`, `LocalFileSystemRepository` in `BackupRepositoryFactory`, `DistributedUpdateProcessorFactory` in `UpdateRequestProcessorChain`, `OpenTelemetryConfigurator` auto-config, the schema designer's suggester, sample loader and `ManagedIndexSchemaFactory`, and the `RestManager` fallback in `SolrCore` - the default `initArgs` field of `SimpleUpdateProcessorFactory` - `ConfigSetProperties.readFromInputStream`, built from a parsed JSON object (unique keys by construction) - `PluginInfo(String, Map)`: nested maps from JSON config become `SimpleOrderedMap`; the top-level `initArgs` stays a `NamedList` because a list of sub-component maps is added under a repeated key - `ApiBag.getCommandOperations`: the throwaway response list only ever receives one `errorMessages` key - `ReplicateFromLeader`: the follower config handed to `ReplicationHandler` No signatures change. `PluginInfo.writeMap` is left as is for now. AI disclosure: the site classification, the edits and this description were drafted with Claude Code and reviewed by me. # Tests No new tests: nothing here is observable through a response. Ran the suites that cover the touched classes: `PluginInfoTest`, `TestConfigSetProperties`, `TestBackupRepositoryFactory`, `TestSchemaCodecFactoryDefaults`, `ReplicateFromLeaderTest`, `UpdateRequestProcessorFactoryTest`, the `handler.designer`, `rest` and `api` packages (60 tests, all pass), plus `./gradlew check -x test`. # Checklist Please review the following and check all that apply: - [x] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability. - [x] I have created a Jira issue and added the issue ID to my pull request title. - [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation) - [x] I have developed this patch against the `main` branch. - [x] I have run `./gradlew check`. - [ ] I have added tests for my changes. - [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) - [ ] I have added a [changelog entry](https://github.com/apache/solr/blob/main/dev-docs/changelog.adoc) for my change (not user-visible; the response-changing slices will carry it) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
