ilariapet commented on code in PR #5293:
URL: https://github.com/apache/solr/pull/5293#discussion_r4550511719
##########
solr/core/src/java/org/apache/solr/search/Grouping.java:
##########
@@ -113,6 +115,16 @@ public class Grouping {
* maxdoc that is allowed in the cache. When this threshold is met, the
cache is not used in
* the second pass search.
*/
+ /** Returns the group heads collected by a single collector as a bitset over
{@code maxDoc}. */
+ public static FixedBitSet retrieveGroupHeads(AllGroupHeadsCollector<?>
collector, int maxDoc) {
Review Comment:
Just a minor: This method was inserted between the constructor’s Javadoc and
the constructor itself. Could you please move it either before the Javadoc or
after the constructor?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
