msfroh commented on PR #5293: URL: https://github.com/apache/solr/pull/5293#issuecomment-6807016559
> This repair targets Lucene main. No Lucene PR has been opened, and a 10.6 maintenance backport or Solr run with patched Lucene has not been verified. Would you like to take the Lucene repair upstream and keep the Solr tests here as integration coverage once the dependency is repaired? I took a look at this PR after being asked by @HoustonPutman. My suggestion would be to try to submit it upstream to Lucene first, and backport it. At first glance, I *think* it seems reasonable. It seems to be properly distinguishing between the case where child documents are being excluded by a filter and a child document matching the filter but having no values. It's pretty complicated, though, so I don't know if I've fully managed to wrap my head around it. As is, some of the "missingWins" logic confuses me, especially as it relates to the parent iterator's `advance()` and `nextDoc()` logic. I'm reading it like if `missingWins` is `true` and *any* child has a missing value, then we skip that parent? That doesn't quite feel right. I'm probably not understanding fully, though. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
