mlbiscoc commented on code in PR #5245:
URL: https://github.com/apache/solr/pull/5245#discussion_r4543602969
##########
solr/core/src/java/org/apache/solr/core/OpenTelemetryConfigurator.java:
##########
@@ -51,8 +59,32 @@ public abstract class OpenTelemetryConfigurator implements
NamedListInitializedP
private static final Logger log =
LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
+ private static final AttributeKey<String> SERVICE_NAME =
AttributeKey.stringKey("service.name");
+ private static final AttributeKey<String> SERVICE_INSTANCE_ID =
+ AttributeKey.stringKey("service.instance.id");
+ private static final AttributeKey<String> HOST_NAME =
AttributeKey.stringKey("host.name");
+
+ /** What the SDK uses for {@code service.name} when nothing configures it. */
+ private static final String UNKNOWN_SERVICE = "unknown_service:java";
+
+ /**
+ * {@code OTEL_METRICS_EXPORTER} as configured, captured before the {@code
opentelemetry} module
+ * overwrites the system property with {@code none}.
+ */
+ private static final String CONFIGURED_METRICS_EXPORTER =
Review Comment:
A bit weird that we read the user value then set to none on the SDK which
makes class loading pinned to each other and order matter. We can hardcode it
to none instead in the auto configurator in otel to none with
`addPropertiesCustomizer`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
