github-actions[bot] commented on PR #5245: URL: https://github.com/apache/solr/pull/5245#issuecomment-6772840766
**Automated PR readiness judgements** (LLM-generated; may be wrong; not updated on later pushes). - ✅ [Jira issue in title](https://github.com/apache/solr/blob/main/CONTRIBUTING.md): already present - ✅ [Changelog](https://github.com/apache/solr/blob/main/dev-docs/changelog.adoc#_changelog_types_reference): type: changed <!-- The change modifies the behavior of existing metrics reporting by populating OpenTelemetry resource attributes (service.name, host.name, etc.) and adding support for standard OTEL environment variables, which alters the labels and configuration behavior visible to users and operators. --> - ✅ [Reference Guide update](https://github.com/apache/solr/tree/main/solr/solr-ref-guide): included <!-- The PR introduces new configuration options (standard OTEL environment variables like OTEL_SERVICE_NAME, OTEL_RESOURCE_ATTRIBUTES, OTEL_METRICS_EXPORTER) and changes the default resource attributes for metrics, which are user-facing behaviors that require documentation in the Reference Guide. --> - ✅ [Upgrade notes](https://github.com/apache/solr/tree/main/solr/solr-ref-guide/modules/upgrade-notes/pages): included <!-- The change alters the labels on pushed metrics (changing job from 'unknown_service:java' to 'solr' and adding instance labels) and enables OTLP export when OTEL_METRICS_EXPORTER is set, which are backwards-incompatible changes for users relying on the previous metric labels or exporter behavior. --> - ✅ Tests: included <!-- The PR modifies non-trivial production logic in OpenTelemetryConfigurator, SolrMetricManager, and MetricExporterFactory to handle resource resolution and exporter configuration, which warrants new or changed tests to verify the behavior. --> <!-- Assessed commit 54896ba7133f3adf05097f3d177381486962a3f5 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
