syahra712 commented on PR #24: URL: https://github.com/apache/solr-orbit-workloads/pull/24#issuecomment-6796575317
Agreed, I've set it to draft. I checked [src-headers](https://www.apache.org/legal/src-headers.html). Files "without any degree of creativity" don't need a header, and the ASF header shouldn't go on third-party content. Going through the seven files: - `files.txt` (×2): just a list of corpus file names, no creative content. - `stopwords.txt` / `synonyms.txt` (×4): each is one auto-generated comment line and nothing else. - `geonames/terms.txt`: place names extracted from the Geonames dataset with `sed | shuf`. That's third-party data, not ASF-authored text. So I don't think any of them needs a header. When RAT is added (#14), I'd list these as excludes in its config rather than adding headers. That would leave this PR empty, so I'm happy to close it, or keep it as a draft until the RAT work if you'd rather. The `terms.txt` comment-skip in `workload.py` only mattered because of the header, so it would go too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
