syahra712 opened a new pull request, #24: URL: https://github.com/apache/solr-orbit-workloads/pull/24
Fixes #15 This adds the standard ASF licence header (the `#` comment block from solr-orbit's `pyproject.toml`) to the seven files listed in the issue. `geonames/workload.py` reads `terms.txt` line by line with no filtering, so on its own the header would have added 16 comment lines as geonames query terms (45,602 terms instead of 45,586). The first commit makes `QueryParamSource` skip lines starting with `#` and blank lines, and opens the file as UTF-8 explicitly. With the header in place it loads the same 45,586 terms in the same order as before; I compared the SHA-256 of the joined term list before and after. The other files are safe as they are: - `stopwords.txt` and `synonyms.txt`: Solr's stopword and synonym parsers ignore `#` lines, and these files already start with a `#` comment. - `files.txt`: nothing in this repo or in solr-orbit reads it today (corpora are downloaded from `workload.json`). Any future mirroring script for #3 should skip `#` lines. Not tested against a live Solr. I didn't add apache-rat; that fits better with the CI in #14. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
