nick-boss-tech commented on PR #5217: URL: https://github.com/apache/solr/pull/5217#issuecomment-6420372954
> a unit test demonstrating the issue? @epugh Yes. The test is on a fork branch rather than this PR: [diff against this branch](https://github.com/jaykay12/solr/compare/SOLR-16398-replication-phase2...nick-boss-tech:solr-16398-v1-commits-shape-test). It adds ReplicationCommitsV1ResponseTest with two cases for command=commits, one with json.nl=flat and one with the default JSON style. Result on each side. Both cases pass on base 07fdebdda54 and fail on this head 9599df2d01f. On this head, each commit entry comes back as a map ({indexVersion=..., generation=..., filelist=[...]}) instead of the flat name/value array. The default json.nl is flat, so callers who don't set a style are affected too, not only the non-default ones. Cherry-pick onto this branch. Validated from a fresh clone of jaykay12/solr: ``` git clone https://github.com/jaykay12/solr.git cd solr git switch SOLR-16398-replication-phase2 git remote add nick https://github.com/nick-boss-tech/solr.git git fetch nick solr-16398-v1-commits-shape-test git cherry-pick d7a6368702f8785fc6cd097641ad1ecd0fe2552e ``` AI-generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
