epugh commented on PR #5217: URL: https://github.com/apache/solr/pull/5217#issuecomment-6414242883
> **Quick Review:** The [v1 commits handler](https://github.com/apache/solr/blob/1de34c883c478dbb6d5a082fd286ae0c917d9193/solr/core/src/java/org/apache/solr/handler/ReplicationHandler.java#L343-L345) now converts commit entries into objects, changing the existing JSON response for callers requesting json.nl=flat or other array styles. Preserve plain NamedList entries in the v1 adapter and add a serialization regression test. The ordinary v2 paths otherwise look coherent. > > AI-generated. Static review. Is this something we can solve in a seperate PR @jaykay12 ? @nick-boss-tech do you by chance have a unit test demonstrating the issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
