nick-boss-tech commented on PR #5225: URL: https://github.com/apache/solr/pull/5225#issuecomment-6389862734
**One P2 test-coverage finding.** The new regex accepts “Could not backup all shards”, which is a generic wrapper for any shard backup error. The test can therefore pass because of an unrelated failure without proving that the forbidden path was rejected. It also weakens the existing Security Manager assertion on JDK 21. Keep the denial-specific assertion where the Security Manager is supported, and require path-specific evidence for the newer-JVM case. [Changed assertion](https://github.com/apache/solr/blob/53ddbf0e857a74b8475b299b0907ac1582be8248/solr/packaging/test/test_security_manager.bats#L53-L54) No production-code defect identified. AI-generated static review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
