[
https://issues.apache.org/jira/browse/SOLR-18119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18124590#comment-18124590
]
Chris M. Hostetter commented on SOLR-18119:
-------------------------------------------
I would love it if every part of our build was pure JVM and didn't require
outside binaries – but progress now is better then perfection later.
* If we've got a patch that gives a clear error if python can't be found, that
sounds better then what we've got right now
* if we've got a patch that optionally let's gradle download GraalPy if python
can't be found, that sounds like a great addition to the first patch
** even better if i people can optionally configure it to force download
GraalPy even if local python exists, so we can have a "officially supported and
version locked" GraalPy codepath that doesn't depend on quirks of the local
python install (3/6 vs 3.7 vs 3.8 vs 3....)
* if at some point someone wants to write a patch that replaces the python
script with something that runs in the JVM ... that sounds even better still
** but we shouldn't sit around twidling our thumbs waiting for that if we
already have the other two patches.
> Changes.html generation is quietly skipped if python3 not found, can cause
> downstream tasks to fail confusingly
> ----------------------------------------------------------------------------------------------------------------
>
> Key: SOLR-18119
> URL: https://issues.apache.org/jira/browse/SOLR-18119
> Project: Solr
> Issue Type: Bug
> Reporter: Chris M. Hostetter
> Assignee: Jan Høydahl
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> ChangesToHtmlTask will log a warning if python3 doesn't exist – but it does
> not fail.
> downstream tasks that (implicitly) depend on the existence of Changes.html
> will subsequently fail...
>
> {noformat}
> :solr:documentation:checkBrokenLinks
> :solr:solr-ref-guide:checkSiteLinks{noformat}
>
> This can be very confusing on jenkins boxes – such as our Windows jenkins
> build, which does not have python3 – when people don't know/realize that
> {{:solr:documentation:changesToHtml}} quietly did nothing.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
