janhoy commented on code in PR #4999:
URL: https://github.com/apache/solr/pull/4999#discussion_r4183828888
##########
gradle/documentation/changes-to-html.gradle:
##########
@@ -65,16 +65,17 @@ abstract class ChangesToHtmlTask extends DefaultTask {
def script
def toHtml() {
- def output = new ByteArrayOutputStream()
-
- // Check if Python is available
- if (!pythonExists()) {
- logger.warn("WARNING: Python is not installed, skipping creating
Changes.html")
- return
+ def python3 = project.externalTool("python3")
Review Comment:
I prefer a variable name like `py3Executable` to describe what it holds
##########
gradle/documentation/changes-to-html.gradle:
##########
@@ -105,9 +106,9 @@ abstract class ChangesToHtmlTask extends DefaultTask {
}
}
- def pythonExists() {
+ def pythonExists(String python3) {
Review Comment:
Same here, use `py3Excecutable` as var name
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
