nick-boss-tech commented on PR #5001: URL: https://github.com/apache/solr/pull/5001#issuecomment-5958895967
Addendum to my JS-testing note above: the absence of a harness does not make the branch untestable, so I ran the real `controllers/logging.js` in Node with the Angular plumbing stubbed out and exercised `setLevel` in all three mode states. Cloud sends `nodes: 'all'`; standalone omits the parameter entirely; and when the flag is still unresolved no request goes out at all until it settles, after which the request follows the settled mode. 12 assertions, all passing. The harness is ad hoc and uncommitted since the repo has no home for legacy-UI JS tests, but I am happy to include it if there is a preferred place for it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
