epugh commented on PR #5001: URL: https://github.com/apache/solr/pull/5001#issuecomment-5957047077
What if we just fix the Solr Admin UI? Is `nodes=all` a common parameter that lots of places ahve that could potentially be fixed through this approach? There is a lot of mock tests and more checks, and I just wonder if we made the one place that causes this issue to be a bit smarter on the caller? Currently in the Solr Admin UI we have lots of places where we consult to decide "am I making this url with a core int he name or a collection in the name"... So understnadin that is there. I'd rather just reuse that logic and then not pass `nodes=all` to a standalone, after all, that just doens't make any sense in user-managed (standalone) mode. (gotta love how we use two names for the same thing everywhere). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
