epugh commented on code in PR #4952:
URL: https://github.com/apache/solr/pull/4952#discussion_r4167502958
##########
solr/core/src/java/org/apache/solr/handler/admin/api/ListCollections.java:
##########
@@ -43,11 +56,31 @@ public ListCollections(CoreContainer coreContainer,
SolrQueryRequest req, SolrQu
@Override
@PermissionName(COLL_READ_PERM)
- public ListCollectionsResponse listCollections() {
+ public ListCollectionsResponse listCollections(
+ Boolean detailed, String collection, String shard, String routeKey,
Boolean prs)
+ throws Exception {
final ListCollectionsResponse response =
instantiateJerseyResponse(ListCollectionsResponse.class);
validateZooKeeperAwareCoreContainer(coreContainer);
+ if (Boolean.TRUE.equals(detailed)) {
+ if (collection != null) {
+ recordCollectionForLogAndTracing(collection, solrQueryRequest);
+ }
+ // Bind only the documented query params; anything else on the request
is ignored.
Review Comment:
i suppose this comment is okay. This is I bleieve the actual default
behavior of all v2 aps...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
