iprithv commented on code in PR #4952:
URL: https://github.com/apache/solr/pull/4952#discussion_r4139228372
##########
solr/webapp/web/js/angular/services.js:
##########
@@ -162,10 +162,9 @@ solrAdminServices.factory('Metrics',
})
.factory('Collections',
['$resource', function ($resource) {
- // v2 ClusterAPI (/api/cluster) delegates straight through to the same v1
CollectionsHandler
- // that v1's CLUSTERSTATUS action used, so the response shape is
byte-identical -- no
- // generated solrApi client class exists for it (old-style @EndPoint API,
predates the
- // OpenAPI-based v2 framework), so this stays a plain $resource, like
Threads/ParamSet.
+ // GET /api/cluster returns {cluster: {collections: ...}}, the
collections, shards, and
+ // replicas tree. Live nodes, the alias map, and cluster properties are
not in this payload.
+ // This stays a plain $resource, like Threads/ParamSet.
return $resource('/api/cluster', {'wt':'json', '_':Date.now()}, {
Review Comment:
ClusterApi.getClusterStatus is generated now (tag cluster)
ClusterV2 already wraps solrApi.ClusterApi...the call sites still use
Collections.status(...) with the $resource callback shape
(data.cluster.collections), so switching means rewriting those controllers to
the error-first generated client style. can we do that as follow-up?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
