nick-boss-tech commented on PR #4959: URL: https://github.com/apache/solr/pull/4959#issuecomment-5939602285
One behavior change worth flagging while reviewing: `cleanupAfterFailure` previously only sent the overseer state update when something actually needed changing (`sendUpdateState`), but the refactored path now always sends the update with the parent pinned to ACTIVE, except when the split already committed (parent INACTIVE + all children ACTIVE). The update is idempotent, so this should be harmless — calling it out in case you’d prefer to keep the old conditional send. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
