nick-boss-tech commented on code in PR #4959:
URL: https://github.com/apache/solr/pull/4959#discussion_r4136916459
##########
solr/core/src/java/org/apache/solr/cloud/api/collections/SplitShardCmd.java:
##########
@@ -1053,6 +1014,46 @@ private void cleanupAfterFailure(
}
}
+ /**
+ * Slice-state rollback for a failed split, or {@code null} if the committed
switch-over must not
+ * be undone. Always includes parent=ACTIVE so a stale snapshot cannot skip
the restore.
Review Comment:
Yes—the helper now restores the parent to ACTIVE unless the parent is
INACTIVE and all split children are ACTIVE, preserving a completed switch-over.
The focused cleanup tests cover both cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
