epugh commented on code in PR #4177:
URL: https://github.com/apache/solr/pull/4177#discussion_r4108546624
##########
solr/webapp/src/test/org/apache/solr/webapp/AdminUiDocumentsScreenTest.java:
##########
@@ -44,6 +44,9 @@ public void testDocumentsScreenForm() {
assertTrue("Doc type dropdown should offer JSON, got " + types,
types.contains("JSON"));
assertTrue("Doc type dropdown should offer XML, got " + types,
types.contains("XML"));
assertTrue("Doc type dropdown should offer CSV, got " + types,
types.contains("CSV"));
+ assertTrue(
+ "Doc type dropdown should offer raw JSON commands, got " + types,
+ types.contains("Solr Command (raw JSON)"));
Review Comment:
yeah... I go back and forth on how deep to go on the tests.. there are
times when I'm like "AI generated it, test everything".. and then others where
I am like "is thre really value in testing everything versus time and cost..."
and so of course, this one bit us. but ai did find the underlying issue
anyway, without the test!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
