epugh commented on PR #4177: URL: https://github.com/apache/solr/pull/4177#issuecomment-5835861203
> > Or we keep the `adds`, `deletes`, `deleteByQuery`: > > My friend Claude has this to say about `touched_docs` vs keeping the three: I'd keep `adds` / `deletes` / `deleteByQuery` rather than collapsing to `touched_docs`. They aren't redundant: a delete-by-query key is a _query_, not an id, and merging them loses that distinction — which is exactly why the PR needed both `VersionedDocument` and `VersionedQuery`. Love it! Thanks for thinking about it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
