nick-boss-tech commented on code in PR #4939:
URL: https://github.com/apache/solr/pull/4939#discussion_r4085345015
##########
solr/core/src/java/org/apache/solr/update/SolrIndexWriter.java:
##########
@@ -229,16 +217,14 @@ protected void merge(MergePolicy.OneMerge merge) throws
IOException {
updateMergeMetrics(totalNumDocs, deletedDocs, segmentsCount, false,
false, null);
try {
super.merge(merge);
- updateMergeMetrics(totalNumDocs, deletedDocs, segmentsCount, true,
false, timer);
} catch (Throwable t) {
- if (timer != null) {
- timer.stop();
- }
+ // SOLR-18135: updateMergeMetrics is the only stop().
Review Comment:
Good point. Removed the ticket-specific source comment in 4b54796.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
