epugh commented on code in PR #4939:
URL: https://github.com/apache/solr/pull/4939#discussion_r4084828141
##########
solr/core/src/java/org/apache/solr/update/SolrIndexWriter.java:
##########
@@ -229,16 +217,14 @@ protected void merge(MergePolicy.OneMerge merge) throws
IOException {
updateMergeMetrics(totalNumDocs, deletedDocs, segmentsCount, false,
false, null);
try {
super.merge(merge);
- updateMergeMetrics(totalNumDocs, deletedDocs, segmentsCount, true,
false, timer);
} catch (Throwable t) {
- if (timer != null) {
- timer.stop();
- }
+ // SOLR-18135: updateMergeMetrics is the only stop().
Review Comment:
no need for this ticket... once this is merged, no one will care about
SOLR-18135!
##########
solr/core/src/test-files/solr/collection1/conf/solrconfig-indexmetrics-failingmerge.xml:
##########
Review Comment:
DO we KNOW that we need to add a new solrconfig to support the tests, and
non of the existing ones can do it?
##########
solr/core/src/test-files/solr/collection1/conf/solrconfig-indexmetrics-failingmerge.xml:
##########
Review Comment:
I know we have a bunch of system properties that let you change test
behaviors..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
