epugh opened a new pull request, #4893: URL: https://github.com/apache/solr/pull/4893
https://issues.apache.org/jira/browse/SOLR-17864 # Description I thought migrating solr.hideStackTrace to solr.responses.stacktrace.enabled would be easy... it had been partly done. Then discovered that in solrconfig.xml and solr.xml, the property substitution didn't leverage the deprecation mechnaism. So: `<str name="hideStackTrace">${solr.hideStackTrace:false}</str>` wouldn't actually read in the `solr.responses.stacktrace.enabled` value, and also didn't take into account that we flipped the value. So you HAVE to do `<str name="hideStackTrace">${solr.responses.stacktrace.enabled:true}</str>` This is potentially a big problem for anyone migrating from older version to newer version who uses this feature. # Solution Rethink a bit how EnvUtils work... Add a Record for tracking properties and their inverted status. Now wires in so older solr.xml etc can participate in reading the deprecated values. # Tests add tests, and then did this script: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
