epugh commented on PR #4280: URL: https://github.com/apache/solr/pull/4280#issuecomment-5600883122
I don't love it. We have more and more tests in our regular `./gradlew test` that require Docker for our test containers, so that doesn't seem a good reason to seperate this test out because of that specific item. Our `./gradlew test` take a while to run, so the fact that this test is slow doesn't seem like a differentator either. I wonder if what we really need is: `./gradlew test` - Our classic java pure unit and the integration tests + FAST bats tests focused on original CLI testing. `./gradlew systemTest` - true system tests like the Selenium tests and the slower .bats tests that have grown to beyond the original cli test plan? The more categories of tests we define, the less that any outside of `./gradlew test` will ever be run. I can't remember the last time I ran the nightly for example. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
