dsmiley commented on code in PR #4877:
URL: https://github.com/apache/solr/pull/4877#discussion_r3938052122
##########
solr/core/src/java/org/apache/solr/update/processor/DocBasedVersionConstraintsProcessor.java:
##########
@@ -440,6 +442,28 @@ public void processAdd(AddUpdateCommand cmd) throws
IOException {
}
}
+ /**
+ * Rejects an update carrying Solr's native <code>_version_</code>. This
processor overwrites that
+ * field to guard its own read-then-write, so a client precondition could
not be honored. Consults
+ * the same sources, in the same order, as {@link
DistributedUpdateProcessor} would.
+ *
+ * <p>NOTE: Perhaps we could do either-or, or combine both somehow.
Review Comment:
meaning, if _version_ is supplied then we pass through, ignoring this URP.
Dubious if that is sound; probably not. Or have the version checking this URP
performs *also* check the version provided against what's in the index. That'd
make sense I guess. Any way, I have no need for such, so deferring till
someone wants that behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
