dsmiley opened a new pull request, #4877:
URL: https://github.com/apache/solr/pull/4877

   This processor uses `_version_` for its own optimistic concurrency; setting 
it on every update so that its read of the existing document's version and the 
subsequent write are atomic. A `_version_` supplied by the client -- on the 
document or as a request parameter -- was therefore overwritten before 
DistributedUpdateProcessor ever read it, so the requested precondition was 
silently not enforced. Adds carrying one are now rejected with a 400.
   
   Also in this change:
   
   * inform() no longer validates the tombstone document shape when 
deleteVersionParam is unconfigured. Tombstones are created solely by the 
Delete-By-Id handling that param enables, so without it the warning about 
uncovered required fields is noise -- and invites curating a tombstoneConfig 
for a code path that can never run.
   
   * Javadoc: say plainly that tombstoneConfig only has an effect alongside 
deleteVersionParam, and document the _version_ incompatibility.
   
   _written mostly with AI_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to