adamjq commented on PR #4698: URL: https://github.com/apache/solr/pull/4698#issuecomment-5545624127
Thanks @alessandrobenedetti, I've addressed your comments and it's ready for review again. Let me know what you think As a side note, `ScalarQuantizedDenseVectorField` arguably shouldn't accept `BYTE` encoding as an option at all. Lucene doesn't quantize BYTE vectors, so it's likely a configuration that would only be arrived at by mistake. It's not directly related to this change, but it could be worth a separate Jira ticket? It would be a minor breaking change -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
