adamjq commented on code in PR #4698:
URL: https://github.com/apache/solr/pull/4698#discussion_r3937375523
##########
solr/core/src/java/org/apache/solr/schema/ScalarQuantizedDenseVectorField.java:
##########
@@ -123,18 +124,28 @@ public void init(IndexSchema schema, Map<String, String>
args) {
super.init(schema, args);
- if (FLAT_ALGORITHM.equals(getKnnAlgorithm())) {
+ if (VectorEncoding.BYTE.equals(getVectorEncoding())
+ && FLAT_ALGORITHM.equals(getKnnAlgorithm())) {
throw new SolrException(
SolrException.ErrorCode.BAD_REQUEST,
- "knnAlgorithm 'flat' is not supported for
ScalarQuantizedDenseVectorField");
+ "vectorEncoding 'BYTE' is not supported for
ScalarQuantizedDenseVectorField"
+ + " with knnAlgorithm 'flat'");
}
}
+ // Unlike DenseVectorField, the scalar-quantized flat format supports KNN
queries.
+ @Override
Review Comment:
Makes sense. I agree - and I've addressed it here:
https://github.com/apache/solr/pull/4698#discussion_r3937372535
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
