Yashgoswami-ds commented on code in PR #4722:
URL: https://github.com/apache/solr/pull/4722#discussion_r3745092194
##########
solr/api/src/java/org/apache/solr/client/api/model/NodeThreadsResponse.java:
##########
@@ -14,23 +14,26 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
-package org.apache.solr.search.facet;
-import com.carrotsearch.randomizedtesting.annotations.Repeat;
-import org.apache.lucene.tests.util.LuceneTestCase.Nightly;
-import org.junit.Test;
+package org.apache.solr.client.api.model;
-/**
- * Nightly variant of {@link SpatialHeatmapFacetsTest} that runs {@code
testPng} the full 3
- * iterations.
- */
-@Nightly
-public class SpatialHeatmapFacetsNightlyTest extends SpatialHeatmapFacetsTest {
+import com.fasterxml.jackson.annotation.JsonProperty;
+import java.util.List;
+import java.util.Map;
+
+public class NodeThreadsResponse extends SolrJerseyResponse {
+
+ @JsonProperty("system")
+ public SystemInfo system;
+
+ public static class SystemInfo {
+ @JsonProperty("threadCount")
+ public Map<String, Object> threadCount;
+
+ @JsonProperty("deadlocks")
Review Comment:
I agree that strongly typed response fields would be preferable. I’ll look
at the existing response models and update this to use appropriate typed
classes where practical.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
