epugh commented on code in PR #4722:
URL: https://github.com/apache/solr/pull/4722#discussion_r3745008252


##########
solr/core/src/java/org/apache/solr/handler/admin/ThreadDumpHandler.java:
##########
@@ -179,12 +178,10 @@ public Category getCategory() {
   public Collection<Api> getApis() {
     return AnnotatedApi.getApis(new NodeThreadsAPI(this));
   }
-
   @Override
   public Boolean registerV2() {

Review Comment:
   i am not totally positive, so need to look at other exampels, but maybe this 
registerV2 goes away, since this sithe v1 way?   i thought the registerV2 was 
basically a way you could have a v1 api particpiate in the old v2 way...  not 
posivite



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to