janhoy commented on PR #4714: URL: https://github.com/apache/solr/pull/4714#issuecomment-5209092286
The goal for this PR was never retryability in itself, that was a draft fix for a suspected cause, but to get to healthy nightly tests. Suggestion for moving forward in solving the flaky `ChaosMonkeySafeLeaderWithPullReplicasTest`: * Recognize that requests from SolrJ towards a solr cluster may fail in may ways, including in a way where we cannot tell whether it was processed on the server, and we cannot safely retry. This is in general something any network client has to live with and accept, and need to implement tailored hardening in the application code. * Harden how the test executes, e.g. by not failing if a simple update fails, but be prepared to retry that update if the particular update itself is idempotent (add with static ID). This will make that part of the test robust against network failures like this. Since the proposed `CloudSolrClient` fix was not a proper solution for this particular test failure, we will remove it from this PR. It may still be valid to harden `CloudSolrClient` by recognizing Jetty's two `Retryable*Exception` as retryable, but that can happen in another PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
