epugh commented on PR #4714: URL: https://github.com/apache/solr/pull/4714#issuecomment-5207067952
> Eric, why do you approve a PR that you admit is out of your depth? fair question... So, I looked at it, and I ran it locally. Things all seem to make sense. So I approved it. But I wanted to caveat that I don't have a ton of confidence in my deep Java and networking skills. From my perspective, this PR looks good, but did want to caveat my approval with the extra detail. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
