dsmiley commented on code in PR #4574:
URL: https://github.com/apache/solr/pull/4574#discussion_r3506626425
##########
solr/core/src/java/org/apache/solr/servlet/HttpSolrProxy.java:
##########
@@ -41,15 +41,19 @@
class HttpSolrProxy {
// TODO add X-Forwarded-For and with comma delimited
- private static final Set<HttpHeader> HOP_BY_HOP_HEADERS =
+ // Headers not to forward: hop-by-hop, plus Host and Content-Length which
the Jetty client
+ // re-derives for the upstream. Forwarding the originals makes Jetty 12.1
reject with a 400.
+ private static final Set<HttpHeader> SKIP_HEADERS =
Review Comment:
Can you please add a link to
https://github.com/jetty/jetty.project/blob/jetty-12.1.x/jetty-ee11/jetty-ee11-proxy/src/main/java/org/eclipse/jetty/ee11/proxy/AbstractProxyServlet.java
somewhere in this source file so that we can compare with another
well-established proxy servlet. I checked and confirmed we can skip
propagating HOST, which is a conditional special-case there.
I'm suspicious of content-length as we should propagate the length if it's
known.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
