janhoy commented on code in PR #4574:
URL: https://github.com/apache/solr/pull/4574#discussion_r3504563428
##########
solr/server/etc/jetty.xml:
##########
@@ -188,40 +188,47 @@
<Set name="dumpAfterStart">false</Set>
<Set name="dumpBeforeStop">false</Set>
- <Call name="addBean">
- <Arg>
- <New id="DeploymentManager"
class="org.eclipse.jetty.deploy.DeploymentManager">
- <Set name="contexts">
- <Ref refid="Contexts" />
- </Set>
- <Call name="addAppProvider">
- <Arg>
- <New class="org.eclipse.jetty.deploy.providers.ContextProvider">
- <Set name="EnvironmentName">core</Set>
- <Set name="monitoredDirName"><Property name="jetty.base"
default="."/>/contexts</Set>
- <Set name="scanInterval">0</Set>
- </New>
- </Arg>
- </Call>
-
- <!-- Add a customize step to the deployment lifecycle -->
- <!-- uncomment and replace DebugBinding with your extended
AppLifeCycle.Binding class
- <Call name="insertLifeCycleNode">
- <Arg>deployed</Arg>
- <Arg>starting</Arg>
- <Arg>customise</Arg>
- </Call>
- <Call name="addLifeCycleBinding">
- <Arg>
- <New class="org.eclipse.jetty.deploy.bindings.DebugBinding">
- <Arg>customise</Arg>
- </New>
- </Arg>
- </Call>
- -->
+ <!-- =========================================================== -->
+ <!-- Deploy the Solr webapp. -->
+ <!-- Solr serves a single, statically-known webapp, so we add it -->
+ <!-- directly to the context collection rather than using Jetty's -->
+ <!-- directory-scanning deployer (the DeploymentManager / -->
+ <!-- ContextProvider API was removed in Jetty 12.1). -->
+ <!-- =========================================================== -->
+ <Ref refid="Contexts">
+ <Call name="addHandler">
+ <Arg>
+ <New class="org.eclipse.jetty.ee10.webapp.WebAppContext">
+ <Set name="contextPath">/solr</Set>
+ <Set name="war"><Property
name="jetty.base"/>/solr-webapp/webapp</Set>
Review Comment:
Let's keep it for now in 10.x, people may have integrations assuming this
location.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
