igiguere commented on PR #4240: URL: https://github.com/apache/solr/pull/4240#issuecomment-4143310399
> This still uses the same security to protect secrets in SysProps right? And envVars are not exposed? There is no change in functionality with regards to system properties and environment variables. This PR adds features that were left out of PR #4078, itself entirely based on pre-exisiting logic. The method `SystemInfoProvider.getInputArgumentsRedacted(NodeConfig, RuntimeMXBean)` is exactly the same as in the patch in https://issues.apache.org/jira/browse/SOLR-16809. The method was just moved to a new class (as part of PR #4078). SystemInfoProvider will output redacted properties according to the `hiddenSysProps` parameter. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
