igiguere opened a new pull request, #4240:
URL: https://github.com/apache/solr/pull/4240

   https://issues.apache.org/jira/browse/SOLR-18161
   
   # Description
   
   Follow-up on PR #4078.  These changes were originally pat of that PR, but 
made it difficult to review and merge.
   
   # Solution
   
   Wrap the V2 system info in "nodeInfo", to separate the system info from the 
response header:
   ```
   <response>
   <lst name="responseHeader"><!-- ... --></lst>
   <lst name="nodeInfo">
   <str name="node">localhost:8983_solr</str>
    <!-- ... -->
   </lst>
   </response>
   ```
   
   Add a method to the API that takes a path parameter to return the select 
info: `lucene`, `jvm`, `gpu`, or `security`
   
   # Tests
   
   Unit tests added or adapted for the wrapped response and the path parameter.
   
   Functional test on "devSlim", running with the "cloud" example.
   
   # Checklist
   
   Please review the following and check all that apply:
   
   - [x] I have reviewed the guidelines for [How to 
Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my 
code conforms to the standards described there to the best of my ability.
   - [x] I have created a Jira issue and added the issue ID to my pull request 
title.
   - [x] I have given Solr maintainers 
[access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork)
 to contribute to my PR branch. (optional but recommended, not available for 
branches on forks living under an organisation)
   - [x] I have developed this patch against the `main` branch.
   - [x] I have run `./gradlew check`.
   - [x] I have added tests for my changes.
   - [x] I have added documentation for the [Reference 
Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
   - [x] I have added a [changelog 
entry](https://github.com/apache/solr/blob/main/dev-docs/changelog.adoc) for my 
change
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to