dsmiley commented on code in PR #4038:
URL: https://github.com/apache/solr/pull/4038#discussion_r2677394050
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/ConcurrentUpdateBaseSolrClient.java:
##########
@@ -550,9 +547,11 @@ public void handleError(Throwable ex) {
/**
* Intended to be used as an extension point for doing post-processing after
a request completes.
*
+ * @param responseMetadata implementation-specific response object (e.g.,
Jetty Response), may be
+ * null
* @param respBody the body of the response, subclasses must not close this
stream.
*/
- public void onSuccess(Response resp, InputStream respBody) {
+ public void onSuccess(Object responseMetadata, InputStream respBody) {
Review Comment:
IMO we shouldn't add generics for an internal matter -- which is what this
is (?). Meaning a user of the client shouldn't have to be confronted with it,
in general.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
