janhoy commented on code in PR #4038:
URL: https://github.com/apache/solr/pull/4038#discussion_r2671886716
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/ConcurrentUpdateBaseSolrClient.java:
##########
@@ -550,9 +547,11 @@ public void handleError(Throwable ex) {
/**
* Intended to be used as an extension point for doing post-processing after
a request completes.
*
+ * @param responseMetadata implementation-specific response object (e.g.,
Jetty Response), may be
+ * null
* @param respBody the body of the response, subclasses must not close this
stream.
*/
- public void onSuccess(Response resp, InputStream respBody) {
+ public void onSuccess(Object responseMetadata, InputStream respBody) {
Review Comment:
@dsmiley Object is simple, I guess a modern alternative is to use generics:
```java
public class ConcurrentUpdateJettySolrClient extends
ConcurrentUpdateBaseSolrClient<org.eclipse.jetty.client.Response>
```
and
```java
public interface StreamingResponse<R>
```
Touches all the same 5 files and all signatures, avoids `Object` but the API
perhaps gets more complicated to understand..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
