gus-asf commented on code in PR #3997: URL: https://github.com/apache/solr/pull/3997#discussion_r2662215378
########## solr/core/src/java/org/apache/solr/servlet/EssentialSolrRequestFilter.java: ########## @@ -0,0 +1,97 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.solr.servlet; + +import jakarta.servlet.FilterChain; +import jakarta.servlet.ServletException; +import jakarta.servlet.http.HttpServletRequest; +import jakarta.servlet.http.HttpServletResponse; +import java.io.IOException; +import java.lang.invoke.MethodHandles; +import org.apache.solr.common.util.SuppressForbidden; +import org.apache.solr.logging.MDCLoggingContext; +import org.apache.solr.logging.MDCSnapshot; +import org.apache.solr.request.SolrRequestInfo; +import org.apache.solr.util.RTimerTree; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +/** + * Servlet Filter to set up and tear down a various things that downstream code in solr relies on. + * It is expected that solr will fail to function as intended without the conditions initialized in + * this filter. Before adding anything to this filter ask yourself if a user could run without the + * feature you are adding (either with an alternative implementation or without it at all to reduce + * cpu/memory/dependencies). If it is not essential, it should have its own separate filter. Also, + * please include a comment indicating why the thing added is essential. + */ +public class EssentialSolrRequestFilter extends CoreContainerAwareHttpFilter { Review Comment: Yes, SOLR-18040 (the parent issue) lays out mostly what I'm going to turn into filters. So the plan is to have filters for at least: 1. Path exclusion 2. MDC/Required (in whatever number of filters we eventually land on) 3. Rate limiting 4. Tracing 5. Auditing 6. Authentication -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
