risdenk commented on code in PR #3997:
URL: https://github.com/apache/solr/pull/3997#discussion_r2662186682
##########
solr/webapp/web/WEB-INF/web.xml:
##########
@@ -46,7 +46,7 @@
<filter>
<filter-name>MDCLoggingFilter</filter-name>
- <filter-class>org.apache.solr.servlet.MdcLoggingFilter</filter-class>
+
<filter-class>org.apache.solr.servlet.EssentialSolrRequestFilter</filter-class>
Review Comment:
Mostly for my own understanding, is there a reason not to have ~3 filters
here instead of one? One for mdc, one for rtimer, etc?
I would guess there is some overhead with each filter, but I would expect
that each filter listed here is "required" so why shove them all into one
filter?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
