dsmiley commented on code in PR #3904:
URL: https://github.com/apache/solr/pull/3904#discussion_r2660199089
##########
solr/core/src/java/org/apache/solr/core/CoreContainer.java:
##########
@@ -1511,6 +1512,16 @@ public SolrCore create(
preExistingZkEntry =
getZkController().checkIfCoreNodeNameAlreadyExists(cd);
}
+ final boolean deleteUnknownCores =
+
EnvUtils.getPropertyAsBool("solr.cloud.delete.unknown.cores.enabled", false);
+ if (deleteUnknownCores && Files.exists(cd.getInstanceDir())) {
Review Comment:
If CorePropertiesLocator was the beast (not CoreContainer), that would
explain why you did what you did, but this is the inverse situation, and you
chose to touch CoreContainer when you could have avoided it. Let's move it
then; ehh? Any way, I'm here for peer review so don't be afraid ;-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
