epugh commented on code in PR #3904:
URL: https://github.com/apache/solr/pull/3904#discussion_r2660081792
##########
solr/core/src/java/org/apache/solr/core/CoreContainer.java:
##########
@@ -1511,6 +1512,16 @@ public SolrCore create(
preExistingZkEntry =
getZkController().checkIfCoreNodeNameAlreadyExists(cd);
}
+ final boolean deleteUnknownCores =
+
EnvUtils.getPropertyAsBool("solr.cloud.delete.unknown.cores.enabled", false);
+ if (deleteUnknownCores && Files.exists(cd.getInstanceDir())) {
Review Comment:
Maybe... Honestly, in this PR, I was attempting to make minimal changes to
CoreContainer as it's a beast already and NOT an area i have worked much in the
past. I don't have a good overall understanding of it as this PR is my first
time actually touching it...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
