epugh commented on code in PR #3904:
URL: https://github.com/apache/solr/pull/3904#discussion_r2658951296
##########
solr/core/src/java/org/apache/solr/core/CoreContainer.java:
##########
@@ -1451,6 +1455,14 @@ public SolrCore create(
preExistingZkEntry =
getZkController().checkIfCoreNodeNameAlreadyExists(cd);
}
+ if (Files.exists(cd.getInstanceDir())) {
Review Comment:
I added a unit test to investigate this ,and what I discovered is that the
core admin level api won't even attempt to delete a remnant because it insists
that you must have a core descriptor in ZK first, so it doesn't even get to
there. I suppose this kind of make sense.
We could extend/augment the core admin level api with some sort of property
that says "Do the delete even though you have no core descriptor" if we wanted
to. However, I think the other way, of just handling it during create
collection and add replica is simpler conceptually for a sys admin person!
Sys admin type person doesn't want to get to the level of understanding what
cores need to be deleted, that is the thrust of this entire feature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
