dsmiley commented on code in PR #3904:
URL: https://github.com/apache/solr/pull/3904#discussion_r2575556326
##########
solr/core/src/java/org/apache/solr/core/CoreContainer.java:
##########
@@ -1451,6 +1455,14 @@ public SolrCore create(
preExistingZkEntry =
getZkController().checkIfCoreNodeNameAlreadyExists(cd);
}
+ if (Files.exists(cd.getInstanceDir())) {
Review Comment:
The error you are trying to avoid, coming out of coresLocate.create, seems
like a relatively fine protection in case a valid core is there. Curious; does
calling a core admin level API to delete the core work? I don't mean replica
deletion.
##########
solr/packaging/test/test_create_collection2.bats:
##########
@@ -0,0 +1,62 @@
+#!/usr/bin/env bats
Review Comment:
I *really* don't think we should add a bats test for matters that JUnit
could easily handle.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
