epugh commented on code in PR #3947:
URL: https://github.com/apache/solr/pull/3947#discussion_r2652100830


##########
solr/test-framework/src/java/org/apache/solr/util/SolrClientTestRule.java:
##########
@@ -68,7 +68,7 @@ public NewCollectionBuilder(String name) {
       this.name = name;
     }
 
-    public NewCollectionBuilder withConfigSet(String configSet) {
+    public NewCollectionBuilder withConfigSet(Path configSet) {

Review Comment:
   So are you saying allow String and Path option (we have lots of Path), or 
just go back to only String?  



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to